Fix: Reduce cadence and number of api calls for Demo-Reviews #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sequentializes the API calls in the
analyze
function as well as adding caching for the DeploymentStatus in order to avoid hitting Secondary Rate Limits we saw in some of our cleanup-processess.Improvements to
DemoDeployment
class:cachedStatus
property to cache the deployment status and modified thegetCurrentStatus
method to use this cache, reducing the number of API calls. [1] [2]Refactoring in
DemoDeploymentReview
class:loadDemoReviews
method to handle demo deployment reviews sequentially, preventing secondary rate limits.Enhancements to test coverage:
DemoDeploymentReview.test.ts
to include new test cases for various demo deployment scenarios, such as identifying demos to warn, terminate, and handle multiple deployments. [1] [2] [3]Utilities for testing:
Mocktokit
utility to support parameter matching in thepaginateCalledWith
method, improving the accuracy of mock API calls.