Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code style, add missing const qualifiers #8279

Closed
wants to merge 1 commit into from

Conversation

halx99
Copy link
Contributor

@halx99 halx99 commented Jan 1, 2025

This will also fix compile error when invoke FindGlyph of a const instance of class ImFont

(Click "Preview" to turn any http URL into a clickable link)

  1. PLEASE CAREFULLY READ: Contributing Guidelines

  2. Clear this template before submitting your PR.

@halx99 halx99 changed the title Improve code style Improve code style, add missing const qualifiers Jan 1, 2025
This will also fix compile error when invoke FindGlyph of a const instance of class ImFont
@ocornut
Copy link
Owner

ocornut commented Jan 6, 2025

Hello,
As explained #4938 this is mostly undesirable: making those functions use const increase the contract surface that ImGui has to honor.
Very concretely I am right now working on changes that requires those to not be const anyway.
Closing this.

@ocornut ocornut closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants