Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Case: Fix #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test Case: Fix #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
oci = {
source = "oracle/oci"
version = "4.96.0" # October 05, 2022 Release
version = "5.1.0"
configuration_aliases = [oci, oci.home_region]
}
}
Expand Down
1 change: 1 addition & 0 deletions test/terraform/budget/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module "budget" {
budget_alert_rule_threshold = var.budget_alert_rule_threshold
budget_alert_rule_message = var.budget_alert_rule_message
budget_alert_rule_recipients = var.budget_alert_rule_recipients
compartment_id = var.home_compartment_id

providers = {
oci = oci
Expand Down
4 changes: 4 additions & 0 deletions test/terraform/budget/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ variable "budget_alert_rule_recipients" {
type = string
default = "[email protected]"
}
variable "home_compartment_id" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get this from somewhere. We might need to create a home compartment to put the tested module in.

type = string
description = "Home Compartment ID"
}
1 change: 1 addition & 0 deletions test/terraform/network/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ module "network" {
workload_compartment_id = module.workload_compartment.compartment_id
additional_workload_subnets_cidr_blocks = var.additional_workload_subnets_cidr_blocks
workload_compartment_name = local.workload_compartment_name
home_compartment_id = module.home_compartment.compartment_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module doesn't seem to exist, I am getting a terraform error running the unittest.


providers = {
oci = oci
Expand Down