[503] Project-wide renaming #1877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
reviewed
Dec 20, 2024
voodoos
force-pushed
the
503-renaming
branch
from
01c1bb0 to
f211402
Compare
Suggested-by: art-w <[email protected]>
voodoos
force-pushed
the
503-renaming
branch
from
7e10b7e to
2ebcb21
Compare
xvw
reviewed
Jan 6, 2025
Comment on lines
+172
to
+175
| in | ||
| Uid_map.find_opt uid related_uids | ||
| |> Option.value_map ~default:Uid_set.empty ~f:Union_find.get | ||
| |> Uid_set.to_list |
There was a problem hiding this comment.
Maybe a detail but:
related_uids
|> Uid_map.find_opt uid
|> Option.value_map
~default:[]
~f:(fun x -> x |> Union_find.get |> Uid_set.to_list)There was a problem hiding this comment.
(feel free to discard the comment)
xvw
reviewed
Jan 6, 2025
| type 'a content = | ||
| | Root of { mutable value : 'a; mutable rank : int } | ||
| | Link of { mutable parent : 'a element } | ||
| and 'a element = { mutable content : 'a content } |
There was a problem hiding this comment.
Why not just defining an element as a ref (since it is exactly the same type)?
and 'a element = 'a content ref
Maybe you will add, in the future, more information?>
xvw
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for project-wide Renaming:
occurrenceswith the new scopeRenaming, Merlin will return all the usages of the definition corresponding to the selected identifier, all the declarations/definitions linked to that definition and all the usages of all these definitions.This PR is based on #1857
Todo