-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of E2k support #4145
Update of E2k support #4145
Conversation
simde changes to support elbrus should be submitted upstream to the simde project (https://github.com/simd-everywhere/simde) , then we can update our simde version once those changes have been submitted. Feel free to submit a PR just for fixing the libcaption warnings. |
Ok. So should I rewind this branch to ff523ab , and then force-push this branch with the only one that commit? |
If you want to do that and rewrite the PR description thats fine too. |
740ee61
to
ff523ab
Compare
Okay @kkartaltepe , I filed a PR for SIMDE, and force-pushed this branch to leave only SIMDE-unrelated commit. |
Those libcaption warnings are already fixed on master, so this PR basically does nothing now. When your E2k changes go through and are ready, then you should make a new PR (can probably copy this PR mostly word for word when that happens). If that's okay at least. |
Uh, right, I haven't checked master recently to see this commit is already there. Thanks. |
I believe so yes. Whenever they update it, then would it be okay if you could recreate this PR with those changes? Sorry for the trouble |
Yes, looks ok for me. So I'll wait till they accept my changes and then create a PR for obs-studio to pull files from updated vesrsion of SIMDE. |
Description
As of support for Elbrus has been introduced in PR #3288, this pull request improves support for building obs-studio on Elbrus hardware platform (which is based on Russian Elbrus CPU family) with its native lcc (eLbrus Compiler Collection) compiler.
Motivation and Context
It allows current master of OBS be built on Elbrus out-of-the-box (and use SIMD functionality with altered version of SIMDE as of this PR).
How Has This Been Tested?
Build and testing plan:
Details of Elbrus workstation:
Details of x86_64 workstation:
Results:
mkdir build; cd build; cmake -DCMAKE_BUILD_TYPE=Release .. && make -j16 && sudo make install
, and ranobs
on both workstations; no suspicious behavior found.Types of changes
Checklist: