fix: send perspective as query param when using POST method
#930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-sanity-module canceled.
|
niklas-may
changed the title
perspective as query param when using POST method
danielroe
reviewed
Nov 15, 2023
|
Thank you ❤️ Yes, that's a good idea to rethink tests but I'm reluctant to hit a real sanity server when testing.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #909 and fixes the same bug as on picosanity where POSTed queries with a perspective return a 400 error.
Note on current test setup: The error is returned from a Sanity server receiving the request. Therefore your current test setup can not detect this error because the
$fetchfunction is mocked.Should we think about refactoring client tests to not mock the
$fetch?