[v1.1][F09-B1]Your TA #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/DeveloperGuide.adoc
Outdated
| |`* *` |user |hide <<private-contact-detail,private contact details>> by default |minimize chance of someone else seeing them by accident | ||
|
|
||
| |`*` |user with many persons in the address book |sort persons by name |locate a person easily | ||
| |`* *` |user |import students/people from a text file |it is easier to enter large numbers of people | ||
|
|
There was a problem hiding this comment.
Make sure for your user stories you are in sync with your target profile.
| @@ -79,4 +79,9 @@ public void saveAddressBook(ReadOnlyAddressBook addressBook, String filePath) th | |||
| XmlFileStorage.saveDataToFile(file, new XmlSerializableAddressBook(addressBook)); | |||
| } | |||
|
|
|||
| @Override | |||
| public void backupAddressBook(ReadOnlyAddressBook addressBook) throws IOException { | |||
| saveAddressBook(addressBook, (filePath + ".bak")); | |||
There was a problem hiding this comment.
Save the extension in a variable
| @@ -0,0 +1,292 @@ | |||
| = Your TA - User Guide | |||
There was a problem hiding this comment.
What is the purpose of this file?
| Alias: `e` + | ||
| Format: `edit INDEX [n/NAME] [p/PHONE] [e/EMAIL] [a/ADDRESS] [t/TAG]...` | ||
|
|
||
| **** |
There was a problem hiding this comment.
Remove text that you do not need
| @@ -9,5 +9,7 @@ | |||
| public static final String MESSAGE_INVALID_COMMAND_FORMAT = "Invalid command format! \n%1$s"; | |||
| public static final String MESSAGE_INVALID_PERSON_DISPLAYED_INDEX = "The person index provided is invalid"; | |||
| public static final String MESSAGE_PERSONS_LISTED_OVERVIEW = "%1$d persons listed!"; | |||
| public static final String MAIL_APP_ERROR = "Error opening the default mail app on this system"; | |||
There was a problem hiding this comment.
Follow the variable naming standard used above. Use names like MESSAGE_MAIL_APP_ERROR
| String firstCharacter = test.substring(0, 1); | ||
| String nextCharacters = test.substring(1, test.length() - 1); | ||
| String lastCharacter = test.substring(test.length() - 1, test.length()); | ||
| return firstCharacter.matches(MATRIC_NUMBER_VALIDATION_REGEX_FIRST) |
There was a problem hiding this comment.
Break up the return statement conditions in two or three steps
whenzei
added a commit
to whenzei/main
that referenced
this pull request
Mar 27, 2018
wynonaK
pushed a commit
to wynonaK/addressbook-level4
that referenced
this pull request
Mar 29, 2018
Added a toggle feature to the application. Toggle is located on the menu, and pressing toggle toggles between a light and dark theme.
Add integration tests for UpdateDisplayCommand
Add comment to mention why files not used
…into UGDG_final
Corrected PPP
update PPP
added_collate_pearlissa
Corrected PPP, and collated final.
Documentation: Update UG/DG broken links and rephrased some portions. Updated figure references as well.
Documentation: Update relevant DG portion
[v1.5] Final changes
Edit error message for markPart
Revert edit
# Conflicts: # collated/functional/Alaru-reused.md # collated/functional/JoonKai1995.md # collated/test/Alaru.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.