scripts: imgtool: fix compression with encryption #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalek-no
requested review from
nvlsianpu,
fundakol,
nordicjm,
de-nordic and
gchwier
michalek-no
force-pushed
the
mb-imgtool-enc-comp
branch
3 times, most recently
from
24b6889 to
f9999b5
Compare
michalek-no
force-pushed
the
mb-imgtool-enc-comp
branch
3 times, most recently
from
58ce51e to
009b3c8
Compare
de-nordic
approved these changes
Jan 9, 2025
adds TLV which stores compressed image size in case encryption is on. This is to avoid wrong streaam size due to encryption padding. Upstream PR #: 2170 Signed-off-by: Mateusz Michalek <[email protected]> (cherry picked from commit a44416620f8475692cc5509532801164e80fb50d)
michalek-no
force-pushed
the
mb-imgtool-enc-comp
branch
from
009b3c8 to
fd8cb31
Compare
…rypted image This TLV is needed in order to know what the data length provided to the decompression system is to remove the padding that is a resultant of the encryption block size Signed-off-by: Jamie McCrae <[email protected]> (cherry picked from commit 4bda587549c0fccd5cd9b59d76c8edf061ee84c3)
nvlsianpu
approved these changes
Jan 15, 2025
|
@michalek-no Are you going to fix git history issue signaled by the |
This probably will be closed after upmerge as not needed. Otherwise yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds TLV which stores compressed image size in case encryption is on. This is to avoid wrong streaam size due to encryption padding.