Resolving Shellcheck SD2086 and SC2046 #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shellcheck results [SC2046](https://www.shellcheck.net/wiki/SC2046) and [SC2086](https://www.shellcheck.net/wiki/SC2086) relate to how variables are handled where they may hold strings with spaces or "glob"ing characters (like `*` and `?`). In this PR, I wrap all script or function calls which pass variables that are themselves variables (`$foo`), or commands (`$(foo)`). Note that this broke the test for generate-contents-with-prefix, so I resolved that by changing `getopt $*` to `getopts` in `src/_adr_generate_toc`.
halostatue
pushed a commit
to halostatue/adr-tools
that referenced
this pull request
Jul 20, 2024
Shellcheck results [SC2046](https://www.shellcheck.net/wiki/SC2046) and [SC2086](https://www.shellcheck.net/wiki/SC2086) relate to how variables are handled where they may hold strings with spaces or "glob"ing characters (like `*` and `?`). In this PR, I wrap all script or function calls which pass variables that are themselves variables (`$foo`), or commands (`$(foo)`). Note that this broke the test for generate-contents-with-prefix, so I resolved that by changing `getopt $*` to `getopts` in `src/_adr_generate_toc`. - Removed non-required loading of config in _adr_dir npryce#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shellcheck results SC2046 and SC2086 relate to how variables are handled where they may hold strings with spaces or "glob"ing characters (like
*and?).In this PR, I wrap all script or function calls which pass variables that are themselves variables (
$foo), or commands ($(foo)).Note that this broke the test for generate-contents-with-prefix, so I resolved that by changing
getopt $*togetoptsinsrc/_adr_generate_toc.This also removes the unnecesary loading of the config file in
_adr_dir.