Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runnable_binary: avoid using > on the output file
In bazel-contrib#1267 there was an issue where, somehow, the wrapper script ended up as a zero-length file but the action succeeded (resulting in storing a zero-length file instead of the script in the caches). genrules are documented as running inside `-ueo pipefail` so it seems like this should be impossible... In any case, this avoids using >$@ because the > runs before the command itself does, creating a zero-length file before populating it, and is the only way I could think of that this ends up as an empty file. Hopefully, if the problem repeats, genrule will notice that the file didn't get created and fail. SH_BINARY_FILENAME also wasn't used, so this skips a step.
- Loading branch information