add fixes for some clippy lints #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, probably a good time for a new version if you have time @not-fl3. There's a few fixes in there now that are not on |
not-fl3
reviewed
Oct 22, 2023
not-fl3
reviewed
Oct 22, 2023
|
@not-fl3 removed those changes you didn't like |
tbh I did not looked any further, I just wanted to illustrate the idea that we might be better off without clippy on the CI |
|
Ah, I hadnt added it to CI, just ran it locally and implemented a couple things i thought looked helpful |
oh, my bad |
not-fl3
approved these changes
Oct 29, 2023
|
@not-fl3 could you do a release of the new version when you have time? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit closes #85, and fixes an issue with the no-std feature cfg. Also a couple clippy lints.
Second commit fixes the
no_stdfeature (which has apparently been broken for a while) and separates thestdandno_stdci runs.