Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: improve panic_hook output. {:?} will show not actually show the error message #509

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

narodnik
Copy link
Contributor

@narodnik narodnik commented Jan 8, 2025

01-08 10:10:50.759 12542 12564 E SAPP    : PanicHookInfo { payload: Any { .. }, location: Location { file: "/usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/ndk-context-0.1.1/src/lib.rs", line: 72, col: 30 }, can_unwind: true, force_no_backtrace: false }

vs

01-08 10:08:59.217 12451 12478 E SAPP    : panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/ndk-context-0.1.1/src/lib.rs:72:30:
01-08 10:08:59.217 12451 12478 E SAPP    : android context was not initialized

…the error message. Instead we should use {}.
@not-fl3
Copy link
Owner

not-fl3 commented Jan 8, 2025

Thanks for PR!

@not-fl3 not-fl3 merged commit 467791b into not-fl3:master Jan 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants