Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synposis
The cost of breaking the batching in macroquad is too big:
410kb
sized buffer on the CPUThis PR aims to eliminate the big allocations on the CPU side of things to reduce the code of breaking the batching.
The fix is based on the assumption that a ~1mb sized batch is very rare and that most of that 1mb is unused space.
The implementation
Instead of using a buffer per draw call, the implementation uses a big contigious buffer. Each DrawCall instead stores
(start, len)
in that buffer, essentially acting as a slice