graphics: Add Normal vertex attribute #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-fl3
commented
Aug 10, 2024
| #[derive(Clone, Debug, Copy)] | ||
| pub struct Vertex { | ||
| pub position: Vec3, | ||
| pub uv: Vec2, | ||
| pub color: Color, | ||
| pub color: [u8; 4], |
There was a problem hiding this comment.
I wish we could use color: Vec4 or color: Color, it would be one extra general purpose attribute for custom shaders. Unfortunately all current shaders expect to receive color in 0..255 range and do this color / 255.0 thing. Lets wait with this for the next major version bump!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Remove VertexInterop thing for good.
People do ask for extra attributes quite often, and I do not thinkg that slightly larger memory footprint will hurt anyone too much.