Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3966): account for network errors #3967

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(#3966): account for network errors #3967

merged 1 commit into from
Dec 19, 2024

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Dec 19, 2024

This relates to...

Closes #3966

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from ronag December 19, 2024 10:15
Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 84a9f85 into main Dec 19, 2024
36 of 37 checks passed
@Uzlopak Uzlopak deleted the fix/3966 branch December 19, 2024 22:35
@remidewitte
Copy link

Thanks.

Do you think it would also work for EHOSTUNREACH errors ?

@metcoder95
Copy link
Member Author

Yes, it should!

@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is retry interceptor only retry http error and ignore dns error?
5 participants