Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make some requires lazy in common/index #56715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 23, 2025

Lazily require child_process and isModuleNamespaceObject only when actually needed.

@jasnell jasnell requested review from mcollina and anonrig January 23, 2025 01:00
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (9ec7bed) to head (dfea11d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56715   +/-   ##
=======================================
  Coverage   89.20%   89.21%           
=======================================
  Files         662      662           
  Lines      191934   191934           
  Branches    36944    36944           
=======================================
+ Hits       171218   171231   +13     
+ Misses      13552    13545    -7     
+ Partials     7164     7158    -6     

see 24 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants