Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enforce strict mode in test-zlib-const #56689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 22, 2025

Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (01dd7c4) to head (d7b39d1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56689      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         662      662              
  Lines      191934   191934              
  Branches    36953    36947       -6     
==========================================
- Hits       171242   171234       -8     
- Misses      13536    13542       +6     
- Partials     7156     7158       +2     

see 37 files with indirect coverage changes

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
Instead of checking that assignments fail silently in sloppy mode, check
that they throw in strict mode.
@Trott
Copy link
Member Author

Trott commented Jan 22, 2025

I rebased to pull in 01dd7c4 from main to fix the unrelated failing tests. Re-approvals would be welcome.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants