-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: disable unneeded rule ignoring in Python linting #56429
Conversation
Removing PLC1901 and RUF100 from the list of Python lint rules to ignore does not result in any errors. Keeping the ignore list as short as possible seems like a good idea, so this change removes them from the ignore list.
@nodejs/python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It would be nice to have a precommit-like capability at the level of the GitHub UI that would complain before the PR was created instead of after the PR is approved. The |
The "merge" operation in this repo has to be performed with
commit-queue
|
I could be misremembering, but I think this is by design. The commit message format is correct but the commit queue hasn't yet added the appropriate metadata. But that happens automatically. Users are not supposed to supply it themselves. This way, it disables the Merge button. We don't want people using the button. We want commits landed through the commit queue. This PR currently has a If I'm mistaken, then sorry for the misinformation! And if I'm correct but there is some way to improve the interface to make it less confusing, let's do that! |
-->
|
Landed in 804d41f |
Removing PLC1901 and RUF100 from the list of Python lint rules to ignore does not result in any errors. Keeping the ignore list as short as possible seems like a good idea, so this change removes them from the ignore list.