Skip to content

Commit

Permalink
fix: Ensure Consistent Order of build_files in WriteAutoRegenerationRule
Browse files Browse the repository at this point in the history
Wrapped the build_files set in the sorted() function before it is processed in WriteAutoRegenerationRule. This ensures that the order of files is consistent across all runs, preventing issues in CI environments that rely on file hash comparisons.
  • Loading branch information
ben-zalekta-lmnd committed Aug 19, 2024
1 parent e6f4ede commit 85166ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gyp/pylib/gyp/generator/make.py
Original file line number Diff line number Diff line change
Expand Up @@ -2383,7 +2383,7 @@ def WriteAutoRegenerationRule(params, root_makefile, makefile_name, build_files)
% {
"makefile_name": makefile_name,
"deps": replace_sep(
" ".join(SourceifyAndQuoteSpaces(bf) for bf in build_files)
" ".join(SourceifyAndQuoteSpaces(bf) for bf in sorted(build_files))
),
"cmd": replace_sep(gyp.common.EncodePOSIXShellList(
[gyp_binary, "-fmake"] + gyp.RegenerateFlags(options) + build_files_args
Expand Down

0 comments on commit 85166ff

Please sign in to comment.