This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Make HTTP_MAX_HEADER_SIZE configurable via gyp #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bnoordhuis
approved these changes
Dec 2, 2018
http_parser.gyp
Outdated
| @@ -56,7 +60,7 @@ | |||
| 'defines': [ 'HTTP_PARSER_STRICT=0' ], | |||
| 'include_dirs': [ '.' ], | |||
| }, | |||
| 'defines': [ 'HTTP_PARSER_STRICT=0' ], | |||
| 'defines': [ 'HTTP_MAX_HEADER_SIZE=<(http_max_header_size)', 'HTTP_PARSER_STRICT=0' ], | |||
There was a problem hiding this comment.
Can you put the directives on their own lines here and below?
mcollina
commented
Dec 3, 2018
| @@ -47,6 +47,10 @@ | |||
| ], | |||
| }, | |||
|
|
|||
| 'variables': { | |||
| 'http_max_header_size%': '8192' | |||
There was a problem hiding this comment.
@bnoordhuis do you think we should change this back to 80KB here? We will be passing down the variable anyway in Node.js.
There was a problem hiding this comment.
I guess it won't hurt backwards compatibility but truthfully, I picked the 80 kb limit at random.
bnoordhuis
approved these changes
Dec 3, 2018
| @@ -47,6 +47,10 @@ | |||
| ], | |||
| }, | |||
|
|
|||
| 'variables': { | |||
| 'http_max_header_size%': '8192' | |||
There was a problem hiding this comment.
I guess it won't hurt backwards compatibility but truthfully, I picked the 80 kb limit at random.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin out from nodejs/node#24716.
This also sets the default to 8KB when compiled via gyp.