-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds exclude_directories input #25
Open
alexmigf
wants to merge
3
commits into
nizarmah:master
Choose a base branch
from
alexmigf:exclude-dirs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ Minifies JS and CSS files with Babel-Minify and CleanCSS | |
| Input | Description | Required | Default Value | | ||
| -- | -- | -- | -- | | ||
| directory | Directory that contains the files you want to minify. | false | . ( current directory ) | | ||
| exclude_directories | Exclude child folders from the main directory. Combine them in a string separated by semicolon and relative to the main directory eg. `dir1;js/dir2;js/test/dir3`. | false | "" (empty) | | ||
| output | Directory that contains the minified files. | false | same as directory | | ||
| overwrite | Overwrites the existing files with the minified version. Defaults to false. | false | false | | ||
| maxdepth | Descend at most levels (a non-negative integer) levels of directories below the starting-points. | false | "" (empty) | | ||
|
@@ -127,3 +128,28 @@ steps: | |
``` | ||
|
||
> Please note that the `repository` when _auto comitting_ has to match `output` in _auto minify_ | ||
|
||
##### Excluding child directories | ||
|
||
``` | ||
steps: | ||
# Checks-out your repository under $GITHUB_WORKSPACE, so auto-minify job can access it | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Auto Minify | ||
uses: nizarmah/[email protected] | ||
with: | ||
directory: 'js' | ||
exclude_directories: 'pdf_js' | ||
|
||
# Auto commits minified files to the repository | ||
# Ignore it if you don't want to commit the files to the repository | ||
- name: Auto committing minified files | ||
uses: stefanzweifel/git-auto-commit-action@v4 | ||
with: | ||
repository: 'js' | ||
commit_message: "Github Action: Auto Minified JS and CSS files" | ||
branch: ${{ github.ref }} | ||
``` | ||
|
||
> Please note that the `exclude_directories` will be relative to the `directory` which here is `js`. In this example the `pdf_js` directory full path would be `js/pdf_js`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexmigf!
Can you switch this please to use line breaks?
Here's an example from StackOverflow.
https://stackoverflow.com/a/75420778/5512292