Add support for scoped context in query #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Feb 28, 2024
marcelklehr
reviewed
Feb 28, 2024
marcelklehr
reviewed
Feb 28, 2024
marcelklehr
reviewed
Feb 28, 2024
marcelklehr
reviewed
Feb 28, 2024
marcelklehr
reviewed
Feb 28, 2024
|
Looks good! 💙 |
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
feat/scoped-context
branch
3 times, most recently
from
95b2e58 to
4a43a39
Compare
marcelklehr
reviewed
Feb 29, 2024
kyteinsky
force-pushed
the
feat/scoped-context
branch
2 times, most recently
from
ca480bb to
fc5ba11
Compare
|
we need to limit php support from 8.0 to 8.2 I suppose |
kyteinsky
force-pushed
the
feat/scoped-context
branch
from
fc5ba11 to
358b69e
Compare
|
something off with gh actions it seems |
|
Github status is back on green |
marcelklehr
reviewed
Feb 29, 2024
gh workflows now check run the check on php 8.0 in addition to 8.1 and 8.2. Also, --no-cache option for psalm Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
feat/scoped-context
branch
from
358b69e to
7372940
Compare
marcelklehr
reviewed
Feb 29, 2024
| "Invalid scope type: {$scopeType}, should be one of: [" . implode(', ', $relection->getConstants()) . ']' | ||
| ); | ||
| } | ||
| } |
marcelklehr
approved these changes
Feb 29, 2024
|
🎉 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.