Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polling new chat message when switching sessions #156

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Nov 20, 2024

closes #154
(This replaces it)

Add a new endpoint to check if a session is in a "thinking" state (meaning it currently has a scheduled/running task).
Use this endpoint to know if we should start polling when switching sessions.

Extra changes:

  • Prevent scheduling multiple llm tasks for one session
  • Fix using incorrect session ID in run/poll methods in the frontend
  • Adjust title generation using the same logic as message generation. Title is written by the listener. Polling starts when switching to a session that has a running/scheduled title generation.

…ng multiple llm tasks for one session

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc added bug Something isn't working 3. to review labels Nov 20, 2024
@julien-nc julien-nc requested a review from kyteinsky November 20, 2024 15:33
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc requested a review from kyteinsky November 25, 2024 16:26
@julien-nc julien-nc merged commit b88fc93 into main Nov 25, 2024
11 checks passed
@julien-nc julien-nc mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants