Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create c.kiminox.net.csr #758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create c.kiminox.net.csr #758

wants to merge 1 commit into from

Conversation

kiminox
Copy link

@kiminox kiminox commented Jan 18, 2025

Checklist

  • Please include a link to your app repository

mgallien
mgallien requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiminox please include a link to your app's repository ?

@mgallien
Copy link
Contributor

@kiminox we think that using your domain name as the id for the app certificate is wrong
see https://docs.nextcloud.com/server/latest/developer_manual/app_development/info.html
the id of the app should follow this rule:

must contain only lowercase ASCII characters and underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiminox @mgallien