chore(dev): added no-floating-promises rule and projectService: true to eslint config
#12440
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue` to eslint config
KostyaTretyak
requested review from
ubbe-xyz and
balazsorban44
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@KostyaTretyak is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Promises must be awaited, end with a call to
.catch, end with a call to.thenwith a rejection handler or be explicitly marked as ignored with thevoidoperator. So, addedno-floating-promisesrules to catch this cases.Added
projectService: trueto fix issue with huge memory consumption.🧢 Checklist