Support e2e tests against multiple NetBox versions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
7 times, most recently
from
23adae8 to
3e98547
Compare
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
from
3e98547 to
845ad6c
Compare
jstudler
approved these changes
Dec 18, 2024
|
To test this locally, execute |
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
from
845ad6c to
c52c6c3
Compare
jstudler
reviewed
Dec 20, 2024
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
from
e58e9ab to
b96d814
Compare
jstudler
reviewed
Dec 20, 2024
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
3 times, most recently
from
7338114 to
bd311b6
Compare
Fix issue with podman Remove exit(1)
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
from
bd311b6 to
0cfa2ea
Compare
|
@alexandernorth PTAL thank you :) |
alexandernorth
approved these changes
Jan 9, 2025
I will create an issue to track this. Thank you @alexandernorth :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reopen #167. Due to PR base branch setting errors, I can't reopen the original PR...)
Since we are introducing the e2e test and running against real NetBox instances, it makes sense to test against different versions of NetBox, so we can flag issues early on.
CI will now run all e2e tests against the supported versions.
The supported NetBox versions are (the latest patch version for the
major.minorrelease):Instead of
create-kind, we now havecreate-kind-3.7.8,create-kind-4.0.11, andcreate-kind-4.1.8. The same goes formake test-e2e.The patching mechanism is used to apply database schema fixes and demo data version changes. When we introduce support for new versions, usually only the database schema would need to be changed.
Blocked by #175 (#177)