Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning on macOS #10282

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix clippy warning on macOS #10282

merged 1 commit into from
Jan 6, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jan 4, 2025

Problem

On macOS:

error: unused variable: `disable_lfc_resizing`
   --> compute_tools/src/bin/compute_ctl.rs:431:9
    |
431 |         disable_lfc_resizing,
    |         ^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `disable_lfc_resizing: _`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

Summary of changes

  • Initialise disable_lfc_resizing only on Linux (because it's used on Linux only in further bloc)

@bayandin bayandin requested a review from a team as a code owner January 4, 2025 15:58
@bayandin bayandin requested review from MMeent and sharnoff January 4, 2025 15:58
Copy link

github-actions bot commented Jan 4, 2025

7227 tests run: 6874 passed, 0 failed, 353 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.2% (8410 of 26948 functions)
  • lines: 48.0% (66769 of 139205 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
40febd7 at 2025-01-04T22:51:36.671Z :recycle:

@bayandin bayandin added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Jan 4, 2025
@bayandin bayandin force-pushed the bayandin/fix-linter-on-macos branch from 36d89f3 to 40febd7 Compare January 4, 2025 21:52
@bayandin bayandin enabled auto-merge January 6, 2025 13:03
@bayandin bayandin added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 02f81b6 Jan 6, 2025
82 checks passed
@bayandin bayandin deleted the bayandin/fix-linter-on-macos branch January 6, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants