Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made fast_import more testable and changed dbname to neondb #10251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NanoBjorn
Copy link
Contributor

@NanoBjorn NanoBjorn commented Dec 31, 2024

Problem

postgres is system database at neon, so we need to do pg_restore into neondb instead

https://github.com/neondatabase/cloud/issues/22100

Summary of changes

Changed fast_import a little bit:

  1. After succesfull connection creating neondb in postgres instance
  2. Changed restore connstring to use new db
  3. Added optional source_connection_string, which allows to skip s3_prefix and just connect directly.
  4. Added -i that stops process until sigterm

TODO

@NanoBjorn NanoBjorn requested a review from a team as a code owner December 31, 2024 16:43
@NanoBjorn NanoBjorn requested review from MMeent and problame and removed request for MMeent December 31, 2024 16:43
Copy link

github-actions bot commented Dec 31, 2024

7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64

Code coverage* (full report)

  • functions: 31.3% (8405 of 26882 functions)
  • lines: 47.9% (66697 of 139109 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
73c14a7 at 2025-01-02T15:01:46.637Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant