queryDirection fixes for LTS (#5889)

* Fix queryDirection interpretation for nested delete

* Add integration tests

* Test modifications for LTS branch

.changeset/tall-months-peel.md

@@ -0,0 +1,5 @@
+---
+"@neo4j/graphql": patch
+---
+
+Fix incorrect relationship direction when performing a delete operation nested under a delete operation

packages/graphql/src/translate/queryAST/ast/selection/RelationshipSelection.ts

@@ -26,7 +26,7 @@ import type { QueryASTContext } from "../QueryASTContext";
 import { EntitySelection, type SelectionClause } from "./EntitySelection";
 
 export class RelationshipSelection extends EntitySelection {
-    private relationship: RelationshipAdapter;
+    protected relationship: RelationshipAdapter;
     // Overrides relationship target for composite entities
     private targetOverride: ConcreteEntityAdapter | undefined;
     private alias: string | undefined;
@@ -64,7 +64,7 @@ export class RelationshipSelection extends EntitySelection {
         const relationshipTarget = this.targetOverride ?? this.relationship.target;
         const targetNode = createNode(this.alias);
         const labels = getEntityLabels(relationshipTarget, context.neo4jGraphQLContext);
-        const relDirection = this.relationship.getCypherDirection(this.directed);
+        const relDirection = this.getRelationshipDirection();
 
         const pattern = new Cypher.Pattern(context.target)
             .related(relVar, { direction: relDirection, type: this.relationship.type })
@@ -81,4 +81,14 @@ export class RelationshipSelection extends EntitySelection {
             selection: match,
         };
     }
+
+    protected getRelationshipDirection(): "left" | "right" | "undirected" {
+        return this.relationship.getCypherDirection(this.directed);
+    }
+}
+
+export class DirectedRelationshipSelection extends RelationshipSelection {
+    protected getRelationshipDirection(): "left" | "right" {
+        return this.relationship.cypherDirectionFromRelDirection();
+    }
 }

packages/graphql/src/translate/queryAST/factory/Operations/DeleteFactory.ts

@@ -28,7 +28,7 @@ import { checkEntityAuthentication } from "../../../authorization/check-authenti
 import type { Filter } from "../../ast/filters/Filter";
 import { DeleteOperation } from "../../ast/operations/DeleteOperation";
 import { NodeSelection } from "../../ast/selection/NodeSelection";
-import { RelationshipSelection } from "../../ast/selection/RelationshipSelection";
+import { DirectedRelationshipSelection } from "../../ast/selection/RelationshipSelection";
 import { getConcreteEntities } from "../../utils/get-concrete-entities";
 import { isInterfaceEntity } from "../../utils/is-interface-entity";
 import { isUnionEntity } from "../../utils/is-union-entity";
@@ -205,9 +205,8 @@ export class DeleteFactory {
             context,
         });
 
-        const selection = new RelationshipSelection({
+        const selection = new DirectedRelationshipSelection({
             relationship,
-            directed: true,
             optional: true,
             targetOverride: target,
         });