Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: short sha has at least four digits #2540

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Nov 23, 2024

Currently it is not very unlikly to have a false match for tag 0 with sha 0XXXXXXXXXXXXXXXXXXXXXXX, 1 to 16

Pending to check if it is possible to match via 3 digests in a repo with almost no commit

Code Usage has been deprecated by me

Fixes #2539

Currently it is not very unlikly to have a false match for tag `0` with sha `0XXXXXXXXXXXXXXXXXXXXXXX`, 1 to 16
Copy link
Contributor

github-actions bot commented Nov 23, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.44s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.9s
✅ REPOSITORY secretlint yes no 1.2s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 5.38s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (5a80a04) to head (8a436d6).
Report is 137 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
+ Coverage   61.56%   68.75%   +7.19%     
==========================================
  Files          53       71      +18     
  Lines        9002    10918    +1916     
==========================================
+ Hits         5542     7507    +1965     
+ Misses       3020     2848     -172     
- Partials      440      563     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX ChristopherHX marked this pull request as ready for review December 1, 2024 14:52
@ChristopherHX ChristopherHX requested a review from a team as a code owner December 1, 2024 14:52
@mergify mergify bot merged commit b4ef6fb into master Dec 24, 2024
12 checks passed
@mergify mergify bot deleted the short-sha-4-digits-and-more branch December 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Act fails when tag doesn't start with "v"
2 participants