-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skal korte ned beskrivelsen på oppgavebenk #2928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rste linje hvis den starter på '---' og slutter på '---'
gunnsteingarmo
requested review from
charliemidtlyng,
ViktorGSolberg,
olekvernberg,
ma10s and
throndi
October 17, 2024 08:57
gunnsteingarmo
changed the title
Skal å korte ned beskrivelsen på oppgavebenk
Skal korte ned beskrivelsen på oppgavebenk
Oct 17, 2024
Kan vi lage en test på dette? |
Det høres lurt ut! Dette er ny kode som egner seg ypperlig for enhetstesting. Vi er jo ingen eksperter på frontend-testing men vi har noe eksempelkode i vedtaksvalidering.test.ts for overgangsstønad og barnetilsyn som du kan ta utgangspunkt i :) |
Godt tenkt. Gjort det nå |
src/frontend/Komponenter/Oppgavebenk/kortNedBeskrivelse.test.ts
Outdated
Show resolved
Hide resolved
src/frontend/Komponenter/Oppgavebenk/kortNedBeskrivelse.test.ts
Outdated
Show resolved
Hide resolved
src/frontend/Komponenter/Oppgavebenk/kortNedBeskrivelse.test.ts
Outdated
Show resolved
Hide resolved
…lles utils fil. Rettet opp i skrivefeil på tester.
ViktorGSolberg
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
Skal alltid fjerne første setning hvis den starter på '---' og slutter på '---'
ellers:
- Hvis "---" oppstår innenfor 75 tegn, klipp bort "---" og alt etter dette (uinteressant informasjon)
- Hvis "---" ikke oppstår innenfor 75 tegn, men det er mer info i beskrivelsen - legg til "..."
- Hvis ikke - vis beskrivelsen
Favro
Før:
Med endringer: