Sende brev uten fagsak #2912
Merged
Sende brev uten fagsak #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for opprettelse av fagsak
…ed søk på person som eksisterer/ikke eksisterer i vårt system
…kke finnes i vårt system.
…frittstående brevfane
ViktorGSolberg
requested review from
charliemidtlyng,
olekvernberg,
ma10s,
throndi and
gunnsteingarmo
src/frontend/Komponenter/Behandling/VedtakOgBeregning/Felles/AvslåVedtak/SelectAvslagÅrsak.tsx
Outdated
Show resolved
Hide resolved
src/frontend/Komponenter/Behandling/VedtakOgBeregning/Felles/AvslåVedtak/SelectAvslagÅrsak.tsx
Outdated
Show resolved
Hide resolved
ViktorGSolberg
commented
Sep 30, 2024
Comment on lines
69
to
80
| <Heading size={'medium'} level={'1'}> | ||
| Opprett fagsak manuelt | ||
| </Heading> | ||
| <AlertInfoPreWrap> | ||
| <BodyLong> | ||
| Denne funksjonen skal brukes hvis du trenger å sende et brev til bruker uten en | ||
| fagsak. | ||
| </BodyLong> | ||
| <BodyLong> | ||
| Et typisk scenario for bruk er når du skal sende et innhentingsbrev til bruker | ||
| for å vurdere retten til overgangsstønad. | ||
| </BodyLong> |
There was a problem hiding this comment.
Denne teksten skal avklares med Mirja og Lars før merge :)
… sende-brev-uten-fagsak
ViktorGSolberg
force-pushed
the
sende-brev-uten-fagsak
branch
from
4e06ea2 to
3062a7f
Compare
|
|
||
| useEffect(() => { | ||
| if (fagsak.status === RessursStatus.SUKSESS) { | ||
| hentFagsakPerson(fagsakPersonId); |
There was a problem hiding this comment.
Mulig jeg er litt treig - men blir man redirectet eller skjer det en sidelast som gjør at man kommer "bort" fra opprett-bildet til brev-bildet?
Ikke så lett å forstå sånn uten videre
There was a problem hiding this comment.
Nei, enig i det. Det som skjer er at man oppretter en fagsak og deretter henter den. Deretter vil denne useEffecten trigges og hente fagsakPerson på nytt. Et hakk opp i komponenthierarkiet vil vi derfor rendre brevfanen i stedet, siden vi nå har en fagsak på denne personen 🤔
There was a problem hiding this comment.
La til en kommentar b037cee
charliemidtlyng
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
https://favro.com/organization/98c34fb974ce445eac854de0/a64c6aad9b0d61ef6c0290bd?card=NAV-22399
Backend PR
navikt/familie-ef-sak#2680