Forenkling groq #709
Merged
Forenkling groq #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma10s
requested review from
charliemidtlyng,
ViktorGSolberg,
olekvernberg,
throndi and
gunnsteingarmo
ma10s
commented
Oct 30, 2024
ma10s
commented
Oct 30, 2024
|
Liker at det er delt opp og at vi har typer på innholdet. Det er litt lettere å forstå hva i alle dager som skjer :D |
Comment on lines
+178
to
+186
| async function hentBrevStruktur( | ||
| datasett: Datasett, | ||
| maalform: Maalform, | ||
| avansertDokumentNavn: string, | ||
| ): Promise<BrevStruktur> { | ||
| const brevmeny: Brevmeny = await hentBrevmenyBlokker(datasett, maalform, avansertDokumentNavn); | ||
| const flettefelter = await hentFlettefelterMedType(datasett, avansertDokumentNavn); | ||
| return { dokument: brevmeny, flettefelter: flettefelter }; | ||
| } |
There was a problem hiding this comment.
Burde denne skrives om til en arrow-function?
ViktorGSolberg
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poc - forenkling og typing. Fortsette, eller tenke annerledes?
relatert til poc ef-sak-frontend
navikt/familie-ef-sak-frontend#2937
som da gjør at vi kan droppe hele denne delen av groq:
(router)
const delmaler: Delmaler = await hentDelmaler(datasett, maalform, avansertDokumentNavn, res);