Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option.prefix #51

Closed
wants to merge 1 commit into from
Closed

Add option.prefix #51

wants to merge 1 commit into from

Conversation

natural-harmonia-gropius
Copy link
Owner

@natural-harmonia-gropius natural-harmonia-gropius commented Jun 6, 2024

Very direct and simple solution, no extra costs. alt to #46 and #47.

mpv.conf

script-opts-append=inputevent-prefix=event:

input.conf

MBTN_LEFT           cycle pause                                                 #event: click
MBTN_LEFT           cycle fullscreen                                            #event: double_click

@tylandercasper @Mark-Joy Any advice?

@tylandercasper
Copy link
Contributor

I think if "event:" is the default going forward than its a cleaner solution.

If it's not the default going forward than the problem is that users get conflicts without knowing that input-event is causing those conflicts. I'm guessing @Mark-Joy was similarly confused at first

Ideally it would be nice to have both the prettier event: clicked syntax and have it bind only to events it can actually respond to.

@natural-harmonia-gropius
Copy link
Owner Author

I think if "event:" is the default going forward than its a cleaner solution.

Breaking change. Put on hold, I want to write a better input.conf parser first.

have it bind only to events it can actually respond to

Okay, I will create a commit with you two as co-author in tomorrow. 👌

@natural-harmonia-gropius
Copy link
Owner Author

natural-harmonia-gropius commented Jun 7, 2024

closed by b996caa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants