Skip to content

Commit

Permalink
[Azure Pipelines] drop old workaround for safaridriver --version (w…
Browse files Browse the repository at this point in the history
…eb-platform-tests#18454)

The `--version` argument is supported starting in Safari 12.1:
web-platform-tests/results-collection#617
  • Loading branch information
foolip authored and natechapin committed Aug 23, 2019
1 parent 6dcdb29 commit 5a2b404
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,7 @@ jobs:
channel: stable
- template: tools/ci/azure/update_hosts.yml
- template: tools/ci/azure/update_manifest.yml
- script: |
# TODO: drop this when `safaridriver --version` is supported.
SAFARI_VERSION="$(/usr/libexec/PlistBuddy -c 'Print :CFBundleShortVersionString' /Applications/Safari.app/Contents/Info.plist) ($(/usr/libexec/PlistBuddy -c 'Print :CFBundleVersion' /Applications/Safari.app/Contents/Info.plist))"
no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info --browser-version "$SAFARI_VERSION" safari
- script: no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info safari
displayName: 'Run tests'
- task: PublishBuildArtifacts@1
displayName: 'Publish results'
Expand Down

0 comments on commit 5a2b404

Please sign in to comment.