Do not enable fibers in tracing-tracy #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Jun 11, 2022
nagisa
force-pushed
the
nagisa/no-fibers-in-tracing
branch
from
1db8d5a to
4b92ef1
Compare
Fibers introduce a significant overhead to each invocation of Tracy instrumentation calls, which in turn makes all tracing instrumentation points (with callstack collection disabled) 2x slower than they could be. I anticipate that `fibers` still may become unconditional requirement in the future due to #35, but there's no reason to impose that overhead on users today.
nagisa
force-pushed
the
nagisa/no-fibers-in-tracing
branch
from
4b92ef1 to
de4325c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fibers introduce a significant overhead to each invocation of Tracy
instrumentation calls, which in turn makes all tracing instrumentation
points (with callstack collection disabled) 2x slower than they could
be.
I anticipate that
fibersstill may become unconditional requirement inthe future due to #35, but there's no reason to impose that overhead on
users today.