FIX(plugins): Load correct pages for modules #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
reviewed
Oct 4, 2024
Hartmnt
added
client
positional audio
bug
This `VirtualQueryEx()` loop is called for each module in a process. It reads pages starting at the module address but seems to continue past into other modules and into dynamic allocations also. This check stops enumerating pages once it encounters one that no longer belongs to the module for which pages are being collected. (Also this function opens two handles, this adds a clean up for the first handle if opening the second fails.) Fixes mumble-voip#6558
sqwishy
force-pushed
the
windows-memory-enumeration
branch
from
d2e2221 to
1498b83
Compare
davidebeatrici
approved these changes
Oct 4, 2024
|
Thank you for finding the cause and submitting a fix! |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hartmnt
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
VirtualQueryEx()loop is called for each module in a process. It reads pages starting at the module address but seems to continue past into other modules and into dynamic allocations also.This check stops enumerating pages once it encounters one that no longer belongs to the module for which pages are being collected.
(Also this function opens two handles, this adds a clean up for the first handle if opening the second fails.)
Fixes #6558
Checks