Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Conditionally skip flaky tests #4627

Merged
merged 2 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion test/integration/propControls/basic.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ test.use({
},
});

test('can control component prop values in properties control panel', async ({ page }) => {
test('can control component prop values in properties control panel', async ({
page,
browserName,
}) => {
// TODO: fix flakyness
test.skip(browserName === 'firefox', 'This test is flaky in firefox');

const editorModel = new ToolpadEditor(page);

await editorModel.goto();
Expand Down
5 changes: 4 additions & 1 deletion test/integration/propControls/defaults.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ test.use({
},
});

test('changing defaultValue resets controlled value', async ({ page }) => {
test('changing defaultValue resets controlled value', async ({ page, browserName }) => {
// TODO: fix flakyness
test.skip(browserName === 'firefox', 'This test is flaky in firefox');

const editorModel = new ToolpadEditor(page);
await editorModel.goto();

Expand Down
Loading