-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[picker] Disable am/pm for maxTime/minTime, disableTime, and disableFuture props #15999
base: master
Are you sure you want to change the base?
Conversation
Hi @flaviendelangle @zannager @LukasTy Could you please review my PR when you have time? I’d love your feedback. |
4b96120
to
2ef5a79
Compare
2ef5a79
to
65d46c3
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Thanks for your contribution |
Do you think it is worth fixing this issue on v7 with a solution similar to what is proposed in this PR? 🤔 |
Fixing by adding props then removing then (so a BC), not sure if it the right move |
That's a good point about the BC break. Adding props temporarily could solve the issue quickly, but it might not be the best move if the props are removed later. If the context-based solution will be ready soon, it might make sense to hold off and go straight to that approach to ensure consistency. However, if addressing the issue now is a priority, we could consider adding the props with clear documentation about their temporary nature. Happy to hear your thoughts and adjust based on the preferred direction! 👍 |
The context-based solution should be available relatively shortly (within 1-2 months). 😉 |
Thanks for the update! Given that the context-based solution is coming soon in v8, what do you think our next steps should be for addressing this issue in v7? |
Unless we have a big traction to fix this issue in v7, I would focus solely on the v8 implementation (and make it as good as possible). |
Changelog
fixed the bug [pickers] Validation doesn't disable meridiem (AM or PM) for selection #12159
I have followed (at least) the PR section of the contributing guide.