[pickers] Use usePickerContext() and usePickerActionsContext() to get the actions in the actionBar slot and in internal components
#15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
breaking change
component: pickers
|
Deploy preview: https://deploy-preview-15843--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
actions-context
branch
from
bb85508 to
77edf42
Compare
flaviendelangle
commented
Dec 11, 2024
| /** | ||
| * Closes the picker and accepts the current value if it is not equal to the last accepted value. | ||
| */ | ||
| dismissViews: () => void; |
There was a problem hiding this comment.
I would love to get rid of this method 😬
It was never used in a public component but was part of the public API since it was passed to PickersLayout ( 🤦 ).
I'm making it private so we can modify it, remove it in the future.
| */ | ||
| open: boolean; | ||
| clearValue: () => void; |
There was a problem hiding this comment.
The main thing I would like to discuss is the naming of those methods.
I tried to be consistent with setOpen (vs onOpen / onClose).
… the actions in the actionBar slot and in internal components
flaviendelangle
force-pushed
the
actions-context
branch
from
77edf42 to
a525f69
Compare
flaviendelangle
changed the title
usePickerContext() and usePickerActionsContext() to get the actions in the actionBar slot and in internal componentsusePickerContext() and usePickerActionsContext() to get the actions in the actionBar slot and in internal components
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/internals/hooks/useDesktopRangePicker/useDesktopRangePicker.tsx
Show resolved
Hide resolved
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
michelengelen
approved these changes
Dec 19, 2024
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/usePicker/usePickerValue.types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
…rValue.types.ts Signed-off-by: Flavien DELANGLE <[email protected]>
lauri865
pushed a commit
to lauri865/mui-x
that referenced
this pull request
Dec 20, 2024
… get the actions in the `actionBar` slot and in internal components (mui#15843) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Michel Engelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15495
Part of #16059
What?
setViewinstead ofonOpenandonCloseon all the internal componentsusePickerActionsContext()to get the actions from the slotsusePickerActionsContext()in all the slots (and remove the props)Why?