Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file_crash_bug] Fix detecting addresses with near allocator poison values #2259

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

suhaibmujahid
Copy link
Member

Fixes #2258

It's a stupid bug where the constant gets created as a generator instead of a tuple. As a result, the first time we call the is_near_allocator_address() function, we get a correct result, but subsequent calls always return False.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid requested a review from marco-c November 1, 2023 05:09
@suhaibmujahid suhaibmujahid enabled auto-merge (squash) November 1, 2023 05:11
@suhaibmujahid suhaibmujahid merged commit 18e4039 into mozilla:master Nov 1, 2023
2 checks passed
@suhaibmujahid suhaibmujahid deleted the fix-near-allocator branch November 1, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bot does not identify "on poison value" addresses when filing bugs for new crashes
2 participants