AnyImage{Importer,Converter}: detect also KTX1 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though KtxImporter / KtxImageConverter doesn't support these (and probably never will), the rationale here is to provide a somewhat better message than "unable to detect file format" when trying to open a *.ktx file, or when trying to save to a *.ktx by accident, instead of *.ktx2 (I do that quite often). The concrete plugins are able to provide a much better error message about version 1 not supported.
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 83.89% 83.90% +0.01%
==========================================
Files 523 523
Lines 33999 34013 +14
==========================================
+ Hits 28524 28540 +16
+ Misses 5475 5473 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
KtxImporter/KtxImageConverterdoesn't support these (and probably never will), the rationale here is to provide a somewhat better message than "unable to detect file format" when trying to open a*.ktxfile, or when trying to save to a*.ktxby accident, instead of*.ktx2(which I do quite often). The concrete plugins are able to provide a much better error message about version 1 not supported.However, this means that once some new plugin actually supports KTX1,
KtxImporterwill still get picked over it, since it always has a precedence over any alias. So this might actually be counterproductive, ending up in the same endless pain as is with the still pretty much uselessly bareboneObjImporterbeing picked overAssimpImporter. Different ideas?*.ktxfile.Ktx1Importer/Ktx1ImageConverter, which won't have any matching plugin in the foreseeable future (and thus also being utterly confusing?)Ktx1Importer/Ktx1ImageConverterfor it? I don't know about any, and integrating Khronos' KTX Software (which depend on GLUT and whatnot) is one thing I definitely did not want and thus went with plugins implemented from scratch instead. OIIO is flexible but doesn't seem to support KTX and there doesn't seem to be any interest in adding that.KtxImporter/KtxImageConverter? Ugh. Actually, integrating KTX Software seems a better idea than wasting time implementing KTX1 myself, but it would need to have some other added value than just being able to work with KTX1.