Generate Brownie interface for Foundry project #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to call `moonworm generate-brownie` with the `--foundry` argument. If it is called this way, the Brownie interface is generated with reference to a Foundry project. Rough around the edges, and may not play nice with `--prod`, which is anyway not working well for deployments (even before the addition of `--foundry`). The same scheme we use to remap the build object for `--foundry` should be generalized across both `--foundry` and `--prod`.
kellan-simiotics
approved these changes
Nov 8, 2023
| help=f"Path to brownie project directory", | ||
| help=f"Path to brownie/foundry project directory", | ||
| ) | ||
| generate_brownie_parser.add_argument( |
There was a problem hiding this comment.
It feels a bit odd to call generate-brownie with a foundry arg. Can we change the name of the method to something more general? If this is too disruptive, we could just expose a duplicate method and say that generate-brownie will eventually be deprecated.
There was a problem hiding this comment.
We are generating a CLI which uses brownie (hence generate-brownie). Against smart contract that are built using foundry.
But I think the larger thing is we need to work on moonworm-rs. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to call
moonworm generate-browniewith the--foundryargument.If it is called this way, the Brownie interface is generated with reference to a Foundry project.
Rough around the edges, and may not play nice with
--prod, which is anyway not working well for deployments (even before the addition of--foundry).The same scheme we use to remap the build object for
--foundryshould be generalized across both--foundryand--prod.