Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding trusted executions to Fullcount contract. #260

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding trusted executions to Fullcount contract. #260

wants to merge 5 commits into from

Conversation

kellan-simiotics
Copy link
Contributor

No description provided.

zomglings
zomglings approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions. Ran tests and everything is passing. Doing second pass now, but it lgtm in general.

src/Fullcount.sol Show resolved Hide resolved
src/Fullcount.sol Show resolved Hide resolved
Reordered FC events alphabetically. Added PitchCommitted, PitchReveal…
b1edca1 
…ed, SwingCommited, SwingRevealed events to Trusted Execution.
zomglings
zomglings approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomglings zomglings zomglings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellan-simiotics @zomglings