First pass at adding profile images. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zomglings unsure why the contract fails in the build. I tried a couple different variants of the ITerminus import path. All of them worked locally, but none in the build. Ideas? I don't think we are using web3 anywhere else. Could it be issue with web3 submodule? |
added 4 commits
March 19, 2024 16:35
…dding setTokenImages method (also batched).
zomglings
approved these changes
Mar 22, 2024
src/Players.sol
Outdated
| adminTerminus = _adminTerminus; | ||
| adminPoolID = _adminPoolID; | ||
|
|
||
| ProfileImages[0] = "https://s3.amazonaws.com/static.fullcount.xyz/Beer_League_Ballers/p0.png"; |
There was a problem hiding this comment.
CDN URL (https://static.fullcount.xyz/...)
| require(terminus.balanceOf(msg.sender, adminPoolID) > 0, "BeerLeagueBallers._enforceIsAdmin: not admin"); | ||
| } | ||
|
|
||
| function addProfileImage(string memory newImage) public { |
There was a problem hiding this comment.
We're probably going to be adding multiple images at once, this seems like it should be a batch method.
There was a problem hiding this comment.
We decided not to do this.
| NumProfileImages++; | ||
| } | ||
|
|
||
| function updateProfileImage(uint256 index, string memory newImage) public { |
There was a problem hiding this comment.
This should also probably be a batch method.
There was a problem hiding this comment.
We decided not to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.