Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding requiresSignature to the AtBat started event. #143

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

kellan-simiotics
Copy link
Contributor

Removed some checks for SessionStarted event in at-bats. The tests still confirm that a new session was created. However, when we test for 2 events, the parameters of the second event don't get verified. Now the event checks correctly fail when the at-bat parameters are incorrect.

Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellan-simiotics kellan-simiotics merged commit b71b45d into main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants