Error handling tweaks #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 14, 2012 17:54
…e that a random one is tried if a host goes down.
This reverts commit cb23a2f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does two things;
When we lose a connection and reconnect, we do so in a strict sequence so that we only ever retry the failed host after trying all the others. The client also shuffles the list of hosts, so that if there is more than two trackers, clients will use the remaining ones when one fails.
We have found the most of the error responses we receive are caused by a particular tracker going bad in some way. Usually, losing database access, or another process making the machine OOM. We thus force a reconnection to a different tracker after every error.