refactor: replace fs-extra with newer fs built-ins
#5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the codebase to remove two uses of fs-extra by newer fs built-in functions. The code changes are based on the implementation of [email protected], which is the version of fs-extra recorded in the project's lockfile. In particular, for `watch.spec.js`, the changes are based on: https://github.com/jprichardson/node-fs-extra/blob/0220eac966d7d6b9a595d69b1242ab8a397fba7f/lib/remove/index.js#L15 and, also for `helper.js`, the changes are based on: https://github.com/jprichardson/node-fs-extra/blob/0220eac966d7d6b9a595d69b1242ab8a397fba7f/lib/mkdirs/make-dir.js#L23
ericcornelissen
changed the title
fs-extra with newer fs built-insfs-extra with newer fs built-ins
ericcornelissen
commented
Jan 2, 2025
| fs.ensureDirSync(path.dirname(dest)); | ||
| fs.copySync(fixtureSource, dest); | ||
| fs.mkdirSync(path.dirname(dest), { recursive: true }); | ||
| fs.cpSync(fixtureSource, dest); |
There was a problem hiding this comment.
From the CI logs, it seems this API is (the only one) missing from Node.js v14. It looks like that version of Node.js only has functions to copy individual files.
@JoshuaKGoldberg I have three suggestions for moving forward:
- Write a custom implementation of
fs.cpSynchere. - Postpone this change until Node.js v14 is no longer run in CI.
- Drop the Node.js v14 job since it's no longer supported.
There was a problem hiding this comment.
Fun timing: #5279 just dropped v14 in CI. If you update this branch from main it should be good to go! 🚀
There was a problem hiding this comment.
Oh, it is updated from main. Investigating...
JoshuaKGoldberg
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This updates the codebase to remove two uses of
fs-extraby newerfsbuilt-in functions. The code changes are based on the implementation of[email protected](which is the version offs-extrarecorded in the project's lockfile).