Various mob CLI improvements. #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When when syncing ledger from scratch, and there are only accounts created recently in the wallet, we should not use min_synced_block_index, but instead use local_block_height to communicate which block the sync status is on.
…e modern protobuf.
christian-oudard
requested review from
holtzman,
jgreat,
joekottke,
nick-mobilecoin,
starkriedesel and
sugargoat
as code owners
|
@christian-oudard you already proposed the first commit in #1013, where it was commented on and then fixed in #1018 for all full-service clients, with the original PR closed. Please remove that change from this PR. Thanks! |
…nd full-service json format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.