Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the format of Dependent Type Definition File #250

Closed
wants to merge 5 commits into from

Conversation

mizdra
Copy link
Owner

@mizdra mizdra commented May 22, 2024

depends: #251

@mizdra mizdra added the Type: Change Change existing functionality. label May 22, 2024
@mizdra mizdra mentioned this pull request May 22, 2024
@mizdra mizdra force-pushed the improve-dependent-type-definition-file branch from 78aaee1 to 9cfbd68 Compare June 8, 2024 05:01
@mizdra mizdra force-pushed the improve-dependent-type-definition-file branch from 7ae5f95 to 81da83a Compare June 9, 2024 09:03
mizdra added 3 commits June 9, 2024 19:10
- Until now, Locator could recursively load multiple css files.
- However, with the change in the loader interface, this no longer happens.
- We now allow concurrent calls to `Locator#load`.
@mizdra mizdra force-pushed the improve-dependent-type-definition-file branch from 81da83a to bc061be Compare June 15, 2024 05:44
;
export default styles;
//# sourceMappingURL=./1.css.d.ts.map
"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c token is missing. This is a breaking change :(

@mizdra
Copy link
Owner Author

mizdra commented Jun 15, 2024

This PR includes a breaking change (#250 (comment)). It causes serious compatibility problems. Therefore, I have decided to reject this PR.

@mizdra mizdra closed this Jun 15, 2024
@mizdra mizdra deleted the improve-dependent-type-definition-file branch June 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Change Change existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant